Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add additional metrics #164

Merged
merged 12 commits into from
Sep 3, 2024
Merged

feat: add additional metrics #164

merged 12 commits into from
Sep 3, 2024

Conversation

mattp-swirldslabs
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs commented Sep 3, 2024 •
edited
Loading

Description:

Related issue(s):

Closes #149 , #150 , #151

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mattp-swirldslabs mattp-swirldslabs added Improvement Code changes driven by non business requirements P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. labels Sep 3, 2024
@mattp-swirldslabs mattp-swirldslabs self-assigned this Sep 3, 2024
@mattp-swirldslabs mattp-swirldslabs changed the title 00149 additional metrics feat: add additional metrics Sep 3, 2024
@mattp-swirldslabs mattp-swirldslabs added this to the 0.1.0 milestone Sep 3, 2024
@mattp-swirldslabs mattp-swirldslabs marked this pull request as ready for review September 3, 2024 16:34
@mattp-swirldslabs mattp-swirldslabs requested a review from a team as a code owner September 3, 2024 16:34
@mattp-swirldslabs
wip: change to enums
b6737dc 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
wip: refactoring
f5b85d8 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
wip
d2ed375 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
wip
a9f91e6 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: one test is working with dagger injection
153ba43 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: refactor
15efd33 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: latest dashboard
ad8bfb2 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: changed the SERVER_OPTS to wait for a remote debugger to attach
5e437b3 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
feat: added additional metrics
c9864be 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: changed method name from setRunning to stopRunning
5d85bcd 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: metric service light refactoring
8c724ec 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
feat: added logging.properties and gradle config to enable Helidon lo…
c0c03be 
…gging

Signed-off-by: Matt Peterson <[email protected]>
AlfredoG87
AlfredoG87 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattp-swirldslabs mattp-swirldslabs merged commit e957565 into main Sep 3, 2024
13 checks passed
@mattp-swirldslabs mattp-swirldslabs deleted the 00149-addl-metrics branch September 3, 2024 20:20
@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (514d2d9) to head (c0c03be).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##                main      #164   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       135       133    -2     
===========================================
  Files             26        27    +1     
  Lines            511       535   +24     
  Branches          27        29    +2     
===========================================
+ Hits             511       535   +24
Files with missing lines Coverage Δ
...va/com/hedera/block/server/BlockStreamService.java 100.00% <100.00%> (ø)
...ava/com/hedera/block/server/ServiceStatusImpl.java 100.00% <100.00%> (ø)
...erver/consumer/ConsumerStreamResponseObserver.java 100.00% <100.00%> (ø)
.../block/server/mediator/LiveStreamMediatorImpl.java 100.00% <100.00%> (ø)
...era/block/server/metrics/BlockNodeMetricTypes.java 100.00% <100.00%> (ø)
...edera/block/server/metrics/MetricsServiceImpl.java 100.00% <100.00%> (ø)
...er/persistence/storage/write/BlockAsDirWriter.java 100.00% <100.00%> (ø)
...ock/server/producer/ProducerBlockItemObserver.java 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlfredoG87 AlfredoG87 AlfredoG87 approved these changes

Assignees

@mattp-swirldslabs mattp-swirldslabs

Labels
Improvement Code changes driven by non business requirements P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Add additional metrics to the block node for observability
2 participants
@mattp-swirldslabs @AlfredoG87